Adding a plugin to calculate the virtual temperature (version 2) #2061
+146
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-philrelton
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2061 +/- ##
========================================
Coverage 98.39% 98.40%
========================================
Files 124 134 +10
Lines 12212 13138 +926
========================================
+ Hits 12016 12928 +912
- Misses 196 210 +14 ☔ View full report in Codecov by Sentry. |
Katie-Howard
requested changes
Dec 9, 2024
mo-philrelton
force-pushed
the
epp1965_virtualtemperature
branch
from
354d649 to
a0b412f
Compare
Katie-Howard
previously approved these changes
Dec 9, 2024
mo-robertneal
previously approved these changes
Dec 11, 2024
mo-philrelton
dismissed stale reviews from mo-robertneal and Katie-Howard
via
9454738
mo-robertneal
approved these changes
Dec 11, 2024
Katie-Howard
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address: https://metoffice.atlassian.net/browse/EPPT-1965
This PR adds a plugin to calculate the virtual temperature based on the air temperature and humidity mixing ratio.
No CLI added due to the move to the DAG runner.
This is a replacement for the closed #2058 to avoid history rewrites and git configuration issues.
Testing:
Ran tests and they passed OK
CLA
If a new developer, signed up to CLA